View Issue Details

IDProjectCategoryView StatusLast Update
0000601luatexluatex bugpublic2011-04-12 11:06
ReporterHans HagenAssigned ToTaco 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionFixed in Version0.66.0 
Summary0000601: node.fields bug
Descriptionan attr_list has no subtype and as a consequence calling node.fields (n.id,n.subtype) reports an error (side effect of more rigurous testing elswhere introduced in rev 4090)

however, fields still returns subtype as valid field and this looks supsicious:

(in texnodes.w)

(1) const char *node_fields_attribute_list[] = { NULL };

(2) {attribute_list_node, attribute_node_size, node_fields_attribute_list,
     "attribute_list"},

as id and subtype seem to be implicicit when an array is passed (1) effectively is { "id", "subtype", NULL } so (2) probably needs to be {attribute_list_node, attribute_node_size, NULL, "attribute_list"} in which case (1) can go

(we probably need to check all field data lists)
TagsNo tags attached.

Activities

Hans Hagen

2011-03-28 16:12

manager   ~0000763

in lua_nodelib_fields(lua_State * L) there is:

    lua_pushstring(L, "subtype");
    lua_rawseti(L, -2, 2);

so we need to move that one to the data tables as there are more node types that have no subtype

Hans Hagen

2011-03-28 16:22

manager   ~0000764

some more info (while testing subtypes):

- node.new(pseudoline_id) : ceashes
- node.new(shape_id) : ceashes

- attributelist, attribute, gluespec, action have no subtypes

Taco

2011-04-12 10:51

administrator   ~0000793

revision 4139:

* suppresses 'subtype' and 'prev' in the node.fields() output of nodes that do not have those fields.
* no longer crashes on allocation of variable sized nodes with a size of zero.

Taco

2011-04-12 11:06

administrator   ~0000799

all fixed in 0.66.0

Issue History

Date Modified Username Field Change
2011-03-28 15:58 Hans Hagen New Issue
2011-03-28 15:58 Hans Hagen Status new => assigned
2011-03-28 15:58 Hans Hagen Assigned To => Taco
2011-03-28 16:12 Hans Hagen Note Added: 0000763
2011-03-28 16:22 Hans Hagen Note Added: 0000764
2011-04-12 10:51 Taco Note Added: 0000793
2011-04-12 10:51 Taco Status assigned => resolved
2011-04-12 10:51 Taco Resolution open => fixed
2011-04-12 11:02 Taco Fixed in Version => 0.66.0
2011-04-12 11:06 Taco Note Added: 0000799
2011-04-12 11:06 Taco Status resolved => closed